feat: Ref/Value behavior tracking #1755
Open
+4,081
−2,136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
reference to something define in that function)
the value proxies
iwoplaza
requested review from
aleksanderkatan,
cieplypolar,
lursz and
reczkok
Contributor
|
Something weird happened to the vaporrave example, some of the effects seem to have disappeared. Also, Slime Mold 3D throws when switching to another example, but this might have been the case before. |
aleksanderkatan
requested changes
Nov 12, 2025
Contributor
aleksanderkatan
left a comment
aleksanderkatan
left a comment
There was a problem hiding this comment.
Great job!
Some of my old comments got lost in the "hidden items".
apps/typegpu-docs/src/content/docs/reference/shader-generation.mdx
Outdated
Show resolved
Hide resolved
| computeLayout.$.inState[currentId].mass < | ||
| computeLayout.$.inState[otherId].mass | ||
| ) { | ||
| const current = computeLayout.$.inState[currentId]; |
Contributor
There was a problem hiding this comment.
It still is weird to me that this translates to a pointer. It makes sense in JS though. This may just be me coming from C, t[i] being equivalent to *(t+i).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
conststatements be pointers if they take in a referential type (let statements)conststatements with naturally non-referential types to be WGSLconst🎉TODO:
const some = layout.$.data) local to functions, and not leak into shell-less functions signatures. This ensures that a function doesn't accidentally have access to a value it shouldn't have access to.Reference assignment errors:
Invalid 'let' statement errors:
